-
-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connectivity_plus): Return multiple active types on MacOS/iOS when available #3083
Conversation
Would appreciate an additional check on how it works on iOS with mobile and wi-fi active as don't have iPhone with a SIM card |
I should be able to do that. Btw, I think we can change the Android implementation to also report the available connections instead of just the used ones, but I don't remember exactly now what was the api. |
Maybe we should implement this change in a different stream listener? In other words:
I know it is more work, but I think there is still a valid use case for the previous implementation. While we implement the rest of the platforms, we can mirror |
For some reason I thought that on Android we already do it this way and return multiple types after introducing this feature with multiple types returned. But seems like I confused something as tested and see that no, we return only the one currently active/used ones.
I like this idea. It would make sense for users, who rely on |
If I remember correctly, the |
Yeah, that is for Android. I meant more Windows/Linux platforms as a subject for research as not really familiar with them. |
I don't see any activity in the related issue, so will just close the PR, considering having no real value in expanding API that way. |
Description
Switching from check for active used connection on iOS/MacOS to available connections to return multiple connection types when such are available. Tested with a dongle for MacBook which has Ethernet port and looks like getting results as expected:
Here is a screenshot from a few more test cases where I tried to connect/disconnect both Wi-Fi and Ethernet
Additionally did a few changes to the API documentation comments.
Related Issues
Closes #3073
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).